[#2037] Workaround for missing statusses from the eSuite statuslist endpoint #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextreme
changed the title
…/open-inwoner into issue/2037-missing-statusses
|
@stevenbal it seems the additional fetch_single_status requires an additional mock, if you have a moment tomorrow please fix the 4 tests. I'll patch 1.13 with this fix accordingly requests_mock.exceptions.NoMockAddress: No mock address: GET https://zaken.nl/api/v1/statussen/3da89990-c7fc-476a-ad13-c9023450083c Ran 1149 tests in 1025.574s FAILED (errors=4) |
stevenbal
force-pushed
the
issue/2037-missing-statusses
branch
from
02a4eee to
68b038d
Compare
stevenbal
approved these changes
Jan 23, 2024
pi-sigma
approved these changes
Jan 23, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #981 +/- ##
===========================================
- Coverage 94.77% 94.76% -0.01%
===========================================
Files 861 861
Lines 30192 30198 +6
===========================================
+ Hits 28614 28618 +4
- Misses 1578 1580 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.